Closed lucab closed 2 years ago
@GuillaumeGomez thanks for the very-very-quick feedback!
Why? You want to change the gir
code to only work with bools? Looks good to me in that case :)
@sdroege yes, in the longer term, possibly. Not an urgent need as I don't think there is anything broken right now. But I think the review comments were right, and being stricter on booleans will help ensuring we aren't unknowingly stepping on other strange cases (e.g. FDs as return codes).
Once this is merged this can be made more strict in gir
or are the more things that need to be fixed first? I'd prefer to have this merged only together with the corresponding gir
change.
I don't have those insights right now, as I haven't yet cooked the gir
change. But I'm ok in leaving this pending a bit longer until then.
gir
patch at https://github.com/gtk-rs/gir/pull/1287. Bump PRs for the usual suspects (gtk-rs-core, gtk3, gtk4, gstreamer) are all green. So yes I think this is the only manual adjustment needed.
This adds a manual implementation for all the GtkBuilder methods that are using unconventional (non gboolean) return codes.
Closes: https://github.com/gtk-rs/gtk3-rs/issues/690