search

gtk-rs / gtk3-rs

Rust bindings for GTK 3
https://gtk-rs.org
MIT License
508 stars 90 forks source link

Auto generate with fixed slice of copy types #695

Closed bilelmoussaoui closed 2 years ago

bilelmoussaoui commented 2 years ago

This PR regenerates with the changes from https://github.com/gtk-rs/gir/pull/1296 along with a fix of GdkAtom's ToGlibContainerFromSlice implementation.

Instead of fixing the generated methods manually, the ToGlibContainerFromSlice was implemented for &Atom which doesn't make a lot of sense since it's a copy type.

GuillaumeGomez commented 2 years ago

Thanks! Please merge once CI pass.

bilelmoussaoui commented 2 years ago

Thanks! Please merge once CI pass.

Can't be merged until the gir change lands

bilelmoussaoui commented 2 years ago

Unless I implement the methods manually and then after the gir PR is merged drop them which is meh :/

sdroege commented 2 years ago

Seems good to me otherwise but this should probably come with some changes in gtk-rs-core too so that BoxedInline types can be converted to an array via as_ptr() directly?

sdroege commented 2 years ago

And in gtk-rs-core this should allow autogenerating more functions in graphene, I think.

sdroege commented 2 years ago

@bilelmoussaoui This needs updating to latest gir and should then be good to go