gtk-rs / gtk3-rs

Rust bindings for GTK 3
https://gtk-rs.org
MIT License
508 stars 90 forks source link

No Gir.toml and .gir files for gdkwayland #729

Open sdroege opened 2 years ago

sdroege commented 2 years ago

@GuillaumeGomez Seems like you forgot to add these :)

bilelmoussaoui commented 2 years ago

Because it is all manual code, gtk3 doesn't expose a gir file for wayland and nobody did the work upstream a long time ago

sdroege commented 2 years ago

I see. Well: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4426

sdroege commented 2 years ago

Doing that was probably easier than manually writing all this

bilelmoussaoui commented 2 years ago

wait, that is it? i thought the issue was more complex than that iirc

sdroege commented 2 years ago

At least it resulted in a .gir file that looked reasonable to me. I added that as part of https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4425 to make sure I got the Since markers right, but I assumed that the autotools build system was already building that.

GuillaumeGomez commented 2 years ago

I'll do it then. :)