search

gtk-rs / gtk3-rs

Rust bindings for GTK 3
https://gtk-rs.org
MIT License
508 stars 90 forks source link

Add example: Combobox with list store #766

Closed ski0090 closed 7 months ago

ski0090 commented 1 year ago

Add an example that utilizes Liststore in Combobox.

GuillaumeGomez commented 1 year ago

Apart from my comments and the clippy lint, looks good to me.

sdroege commented 1 year ago

the clippy lint

@GuillaumeGomez That's from old code and a new clippy lint, and because we always use latest beta this now triggers for an unrelated PR. Want to send a PR to fix the clippy lint?

ski0090 commented 1 year ago

Apart from my comments and the clippy lint, looks good to me.

@GuillaumeGomez @sdroege thanks for the review

ski0090 commented 1 year ago

@bilelmoussaoui Opinion applied. thanks for the review

ski0090 commented 7 months ago

@GuillaumeGomez @bilelmoussaoui Can i merge?

GuillaumeGomez commented 7 months ago

Thanks!