Remove unnecessary upcast from examples/squeezer_bin/main.rs - Githubissues

gtk-rs / gtk4-rs

Rust bindings of GTK 4

https://gtk-rs.org/gtk4-rs/

MIT License

1.75k stars 168 forks source link

Remove unnecessary upcast from examples/squeezer_bin/main.rs #1763

Closed mtilda closed 3 weeks ago

mtilda commented 1 month ago

I noticed this example runs as expected even without .upcast::<gtk::Widget>()

I have a limited understanding of the language and libraries. I welcome pedantic feedback.

What I understand is that

SqueezerBin.set_child() expects an argument of type Option<&gtk::Widget> https://github.com/gtk-rs/gtk4-rs/blob/53407150ab1f46494c767614783b06958a418613/examples/squeezer_bin/squeezer_bin/imp.rs#L26
gtk::Label extends gtk::Widget, so I believe the type constraint is already satisfied https://github.com/gtk-rs/gtk4-rs/blob/53407150ab1f46494c767614783b06958a418613/gtk4/src/auto/label.rs#L36

Try it yourself

Clone this repository
cd in the examples directory
Run the command cargo run --bin squeezer_bin

mtilda commented 1 month ago

@bilelmoussaoui any thoughts on this? Have you found time to test the change?