search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

cairo-rs update breaks pangocairo-sys #116

Closed vhdirk closed 5 years ago

vhdirk commented 5 years ago

pangocairo fails to compile since the cairo enums have all been exported at the crate root instead of under the 'enums' module.

error[E0433]: failed to resolve. Could not find `enums` in `cairo`                                                                                                                  
  --> /home/dvhaeren/.cargo/git/checkouts/sys-5eecc06807450db7/e10e6ef/pangocairo-sys/src/lib.rs:74:68                                                                              
   |                                                                                                                                                                                
74 |     pub fn pango_cairo_font_map_new_for_font_type(fonttype: cairo::enums::FontType) -> *mut pango::PangoFontMap;                                                               
   |                                                                    ^^^^^ Could not find `enums` in `cairo`                                                                     

error[E0433]: failed to resolve. Could not find `enums` in `cairo`                                                                                                                  
  --> /home/dvhaeren/.cargo/git/checkouts/sys-5eecc06807450db7/e10e6ef/pangocairo-sys/src/lib.rs:76:90                                                                              
   |                                                                                                                                                                                
76 |     pub fn pango_cairo_font_map_get_font_type(fontmap: *mut PangoCairoFontMap) -> cairo::enums::FontType;                                                                      
   |
EPashkin commented 5 years ago

Thanks for reporting

vhdirk commented 5 years ago

Any preferred way of fixing this? I can supply a PR to cairo to export the 'enum' module, or is this something that needs to be fixed in gir?

EPashkin commented 5 years ago

I start adding PRs.

EPashkin commented 5 years ago

PR with https://github.com/EPashkin/pangocairo/commit/201fcdc58568d13ddac15681b8884899cc6fc2e1 will be added after sys fixed