Add gtk4 files - Githubissues

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.

http://gtk-rs.org/

MIT License

31 stars 25 forks source link

Add gtk4 files #145

Closed sfanxiang closed 5 years ago

sfanxiang commented 5 years ago

Squashed from https://github.com/sfanxiang/gtk-rs-sys/commits/gtk4, due to large merge conflicts.

[ ] Appveyor CI is not available
[x] Travis CI depends on having https://github.com/gtk-rs/examples4
[x] Depends on https://github.com/gtk-rs/gir-files/pull/39

sdroege commented 5 years ago

Looks good to me. For the Travis CI, why does it depend on the example? Can't we build things without the GTK4 examples for now and once everything is in place enable the examples?

sfanxiang commented 5 years ago

@sdroege Dropped gtk4 examples.

alatiera commented 5 years ago

Looks good to me as well.

sdroege commented 5 years ago

What has to be done for appveyor here? I see that it's green, but travis is not :)

EPashkin commented 5 years ago

Appveyor don't have regen check IMHO this PR missed 3 thing:

update rust to 1.36.0 in .travis.yml,
update submodules
full regen: old version.txt need changed too.

EPashkin commented 5 years ago

@sfanxiang Thanks

EPashkin commented 5 years ago

👍

sdroege commented 5 years ago

Let's get this in then, I'd say? :)

sfanxiang commented 5 years ago

Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?

Thanks for reviewing, by the way.

sdroege commented 5 years ago

Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?

I don't know, it was ready from my side 6 days ago already.

@GuillaumeGomez ?

GuillaumeGomez commented 5 years ago

Arf sorry! Might have missed the notification (don't hesitate to ping us in such cases!)...