Closed sfanxiang closed 5 years ago
Looks good to me. For the Travis CI, why does it depend on the example? Can't we build things without the GTK4 examples for now and once everything is in place enable the examples?
@sdroege Dropped gtk4 examples.
Looks good to me as well.
What has to be done for appveyor here? I see that it's green, but travis is not :)
Appveyor don't have regen check IMHO this PR missed 3 thing:
@sfanxiang Thanks
👍
Let's get this in then, I'd say? :)
Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?
Thanks for reviewing, by the way.
Hi all, what's the status on this? Can we please merge this or is there anything I'm supposed to do?
I don't know, it was ready from my side 6 days ago already.
@GuillaumeGomez ?
Arf sorry! Might have missed the notification (don't hesitate to ping us in such cases!)...
Squashed from https://github.com/sfanxiang/gtk-rs-sys/commits/gtk4, due to large merge conflicts.