search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

Remove graphene #149

Closed sfanxiang closed 5 years ago

sfanxiang commented 5 years ago

graphene is now in its own repo.

cc @GuillaumeGomez @sdroege

sdroege commented 5 years ago

What do you mean with it being in its own repo? Wasn't the goal to have the -sys part here and the other part in gtk-rs/graphene?

sfanxiang commented 5 years ago

@sdroege

@alatiera suggested moving graphene-sys to the graphene repo for easier maintenance, and @GuillaumeGomez agreed. graphene-sys now lives at https://github.com/gtk-rs/graphene/tree/master/graphene-sys.

GuillaumeGomez commented 5 years ago

I didn't agree. I said it was an acceptable solution just like doing nothing and took sourceview as an example. You'll note that sourceview is the only "main" gtk-rs repository which owns its own sys part.

sdroege commented 5 years ago

You'll note that sourceview is the only "main" gtk-rs repository which owns its own sys part.

cairo too :)

I don't mind either way. Just keep it in the sys repo for the other 3 crates for consistency with the gtk3 versions.

alatiera commented 5 years ago

I am also fine either way, since its somewhat standalone module, I think its easier to have both crates in the same repo. Would be fine otherwise as well if the other way around is preferred.

sdroege commented 5 years ago

As that's how the gtk-rs/graphene repo is now, let's get this PR merged I guess!