search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

Regen #152

Closed GuillaumeGomez closed 4 years ago

GuillaumeGomez commented 4 years ago

cc @sdroege @EPashkin

Follow-up of https://github.com/gtk-rs/gir-files/pull/43.

sdroege commented 4 years ago

Otherwise looks good to me

GuillaumeGomez commented 4 years ago

Problem now is that we have https://developer.gnome.org/gtk4/stable/GtkCssProvider.html#GtkCssProvider-parsing-error "section" parameter which has a type with no name. Which is weird. Then I look around to check for the CssSection and found nothing. Really weird. What "name" should I put in the fix so it works?

EPashkin commented 4 years ago

Very strange, <record name="CssSection" c:type="GtkCssSection" was in previous version.

EPashkin commented 4 years ago

Also missing CssLocation

GuillaumeGomez commented 4 years ago

I suggest to just ignore the last version of those gir-files. It's completely broken...

EPashkin commented 4 years ago

Agree that we can ignore gtk4 now and undo changes

GuillaumeGomez commented 4 years ago

Merging as is is fine I guess?

EPashkin commented 4 years ago

IMHO yes

GuillaumeGomez commented 4 years ago

Let's wait for @sdroege approval first then.

sdroege commented 4 years ago

Agree that we can ignore gtk4 now and undo changes

I think gir is broken then :) The gir files are working fine with other bindings and should work. Needs further investigation.

GuillaumeGomez commented 4 years ago

A <type> is supposed to have a name, that's the issue. Doesn't seem to come from us. :-/

sdroege commented 4 years ago

A <type> is supposed to have a name, that's the issue. Doesn't seem to come from us. :-/

Did someone create an issue against gtk4 for that?

GuillaumeGomez commented 4 years ago

No? :)

sdroege commented 4 years ago

Please do that then :) And also create a new issue in this repo so we don't forget to update gtk4 before the next release.

GuillaumeGomez commented 4 years ago

Do you know where we're supposed to open such an issue btw?

sdroege commented 4 years ago

https://gitlab.gnome.org/GNOME/gtk/issues/new

GuillaumeGomez commented 4 years ago

Thanks!

GuillaumeGomez commented 4 years ago

Opened https://gitlab.gnome.org/GNOME/gtk/issues/2230

sdroege commented 4 years ago

Then also an issue here and an entry in the release tracker issue, and then merge :)