Closed GuillaumeGomez closed 4 years ago
Otherwise looks good to me
Problem now is that we have https://developer.gnome.org/gtk4/stable/GtkCssProvider.html#GtkCssProvider-parsing-error "section" parameter which has a type with no name. Which is weird. Then I look around to check for the CssSection
and found nothing. Really weird. What "name" should I put in the fix so it works?
Very strange, <record name="CssSection" c:type="GtkCssSection"
was in previous version.
Also missing CssLocation
I suggest to just ignore the last version of those gir-files. It's completely broken...
Agree that we can ignore gtk4 now and undo changes
Merging as is is fine I guess?
IMHO yes
Let's wait for @sdroege approval first then.
Agree that we can ignore gtk4 now and undo changes
I think gir is broken then :) The gir files are working fine with other bindings and should work. Needs further investigation.
A <type>
is supposed to have a name, that's the issue. Doesn't seem to come from us. :-/
A
<type>
is supposed to have a name, that's the issue. Doesn't seem to come from us. :-/
Did someone create an issue against gtk4 for that?
No? :)
Please do that then :) And also create a new issue in this repo so we don't forget to update gtk4 before the next release.
Do you know where we're supposed to open such an issue btw?
Thanks!
Then also an issue here and an entry in the release tracker issue, and then merge :)
cc @sdroege @EPashkin
Follow-up of https://github.com/gtk-rs/gir-files/pull/43.