search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

Focal #164

Closed EPashkin closed 4 years ago

EPashkin commented 4 years ago

@GuillaumeGomez, @sdroege Based on #163 and rebased/fixed https://github.com/gtk-rs/gir-files/pull/52

GuillaumeGomez commented 4 years ago

Lot of removal, I guess it's good sign. :)

EPashkin commented 4 years ago

Some good changes on generated Gtk: https://github.com/gtk-rs/gtk/pull/992. but 3 next get_types in pango not covered by version (almost https://github.com/gtk-rs/gir/issues/839, but for objects)

  = note: D:\eap\rust\0\target\debug\deps\libpango-b358e10e9aaf6d7d.rlib(pango-b358e10e9aaf6d7d.2tb271hmdllqn86k.rcgu.o): In function `_$LT$pango..auto..attr_iterator..AttrIterator$u20$as$u20$glib..types..StaticType$GT$::static_type::hb4e07d2834647594':                                         
D:/eap/rust/0/pango\src\auto/attr_iterator.rs:18: undefined reference to `pango_attr_iterator_get_type'                                       
D:\eap\rust\0\target\debug\deps\libpango-b358e10e9aaf6d7d.rlib(pango-b358e10e9aaf6d7d.3giwo7h1to4sw6ii.rcgu.o): In function `_$LT$pango..auto..attribute..Attribute$u20$as$u20$glib..types..StaticType$GT$::static_type::h4b7cdf886b2aa0f5':                                                
D:/eap/rust/0/pango\src\auto/attribute.rs:16: undefined reference to `pango_attribute_get_type'                                               
D:\eap\rust\0\target\debug\deps\libpango-b358e10e9aaf6d7d.rlib(pango-b358e10e9aaf6d7d.209astijk3vza7pa.rcgu.o): In function `_$LT$pango..auto..coverage..Coverage$u20$as$u20$glib..types..StaticType$GT$::static_type::hee8f58f0b0103868':                                                  
D:/eap/rust/0/pango\src\auto/coverage.rs:16: undefined reference to `pango_coverage_get_type'
EPashkin commented 4 years ago

Added temporary hack for linking, examples/pango_attributes still works with it.

EPashkin commented 4 years ago

Updated to https://github.com/gtk-rs/gir-files/pull/55 This PR still contains HACK for pango missing get_types.

sdroege commented 4 years ago

This PR still contains HACK for pango missing get_types.

The hack is that older versions didn't have get_type() functions for these enums but now there is one? It would be better to only create the glib::Value related trait impls for these enums when the corresponding feature is selected then. Unfortunately it's not representable in the .gir file that the enums existed since long before but the get_type() function is new, so we'll have to configure that on our side in the Gir.toml.

What do you think @EPashkin ?

sdroege commented 4 years ago

Looks good to me otherwise

EPashkin commented 4 years ago

Updated without atk_plug_set_child

EPashkin commented 4 years ago

Updated

sdroege commented 4 years ago

@GuillaumeGomez This and everything but pango is good to go then