Closed kinnison closed 4 years ago
IMHO not problem use gdk-sys directly (as gtk does) so adding it to gtk-sys is unnecessary
SO it does, I'll remove it from gtk-sys. Sorry for the noise.
👍
The failure here appears to be related to make regen-check
which I thought was only for the Gir autogenerated files, but it appears to have affected build.rs
too - so I'll need to chase that down. I'll try and get to it later today.
For -sys, Cargo.toml and build.rs are unfortunately also autogenerated. I have to fight with manual changes in them in gstreamer-rs too
@sdroege Thanks, I guess this one will be a little more faffy than I'd hoped :/
Sorry, I forgot about that one too. @EPashkin do you have any suggestions how to somehow make this work together with the generation of those files from gir?
@sdroege , @kinnison Sorry, I missed that when made suggestion.
We can add option that moves most changed block - calculating version
to separate file (Ex. build_version.rs) and not update build.rs if it already present.
Added PRs for proposed option example
I'll update this PR later today
Sorry for the delay, work got crazy for a few days. how does that look?
@kinnison Thanks, looks good. You already updated gtk part?
I have a PR branch ready for the GTK stuff, I'll file it later when I'm back at my laptop
OK, I'm ready with the GTK part (though it won't hurt for the sys part to go in first) Once this is merged, I can file the GTK PR since that'd fail until the sys part is merged.
cc @GuillaumeGomez , @sdroege
@GuillaumeGomez CI is green
Thanks!
In gdk-sys we compute the available backends and export them both to dependencies and to the code in the form of cfg vars. In gtk-sys we consume the output of gdk-sys, reexport it for users of gtk-sys and again expose it to the code in the form of cfg vars.
This is part of refactoring some work I did previously in the gtk repository so that the computation of the backends is done once where it properly belongs, in gdk-sys.