search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

gdk/gdk: build: Compute and export GDK backends #167

Closed kinnison closed 4 years ago

kinnison commented 4 years ago

In gdk-sys we compute the available backends and export them both to dependencies and to the code in the form of cfg vars. In gtk-sys we consume the output of gdk-sys, reexport it for users of gtk-sys and again expose it to the code in the form of cfg vars.

This is part of refactoring some work I did previously in the gtk repository so that the computation of the backends is done once where it properly belongs, in gdk-sys.

EPashkin commented 4 years ago

IMHO not problem use gdk-sys directly (as gtk does) so adding it to gtk-sys is unnecessary

kinnison commented 4 years ago

SO it does, I'll remove it from gtk-sys. Sorry for the noise.

EPashkin commented 4 years ago

👍

kinnison commented 4 years ago

The failure here appears to be related to make regen-check which I thought was only for the Gir autogenerated files, but it appears to have affected build.rs too - so I'll need to chase that down. I'll try and get to it later today.

sdroege commented 4 years ago

For -sys, Cargo.toml and build.rs are unfortunately also autogenerated. I have to fight with manual changes in them in gstreamer-rs too

kinnison commented 4 years ago

@sdroege Thanks, I guess this one will be a little more faffy than I'd hoped :/

sdroege commented 4 years ago

Sorry, I forgot about that one too. @EPashkin do you have any suggestions how to somehow make this work together with the generation of those files from gir?

EPashkin commented 4 years ago

@sdroege , @kinnison Sorry, I missed that when made suggestion. We can add option that moves most changed block - calculating version to separate file (Ex. build_version.rs) and not update build.rs if it already present.

EPashkin commented 4 years ago

Added PRs for proposed option example

kinnison commented 4 years ago

I'll update this PR later today

kinnison commented 4 years ago

Sorry for the delay, work got crazy for a few days. how does that look?

EPashkin commented 4 years ago

@kinnison Thanks, looks good. You already updated gtk part?

kinnison commented 4 years ago

I have a PR branch ready for the GTK stuff, I'll file it later when I'm back at my laptop

kinnison commented 4 years ago

OK, I'm ready with the GTK part (though it won't hurt for the sys part to go in first) Once this is merged, I can file the GTK PR since that'd fail until the sys part is merged.

EPashkin commented 4 years ago

cc @GuillaumeGomez , @sdroege

sdroege commented 4 years ago

@GuillaumeGomez CI is green

GuillaumeGomez commented 4 years ago

Thanks!