gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

Depend on cairo-sys when selectin v3_24_2 feature #173

Closed sdroege closed 4 years ago

sdroege commented 4 years ago

Fixes https://github.com/gtk-rs/sys/issues/172

GuillaumeGomez commented 4 years ago

Nice, thanks!

sdroege commented 4 years ago

Hm that's not how it works because gir would overwrite the changes. @EPashkin ? :)

EPashkin commented 4 years ago

You can change crate to edition2018 and add use cairo_sys as cairo; in manual.rs instead

sdroege commented 4 years ago

You can change crate to edition2018 and add use cairo_sys as cairo; in manual.rs instead

That doesn't change the problem in Cargo.toml though :)

And you can also do cairo = { package = "cairo-sys-rs", ...} in Cargo.toml instead.

EPashkin commented 4 years ago

Cargo.toml for feature "v3_24_2" can be fixed with

[[feature_dependencies]]
version = "3.24.2"
dependencies = [
  "cairo-sys-rs"
]
sdroege commented 4 years ago

Oh indeed, thanks :) Done! (Also 2018 edition is not needed for this)

EPashkin commented 4 years ago

Oh indeed, thanks :) Done! (Also 2018 edition is not needed for this)

Only because it already edition2018 😉

EPashkin commented 4 years ago

@sdroege Thanks, 👍

sdroege commented 4 years ago

@GuillaumeGomez CI is green :)

GuillaumeGomez commented 4 years ago

Thanks!