Pangocairo

[GuillaumeGomez]

cc @EPashkin

It currently needs this update to work. Then I'll update the Cargo.toml.

(I'll clean everything once the other one is merged because the history seems like a huge mess.)

[EPashkin]

@GuillaumeGomez you don't forget about https://crates.io/crates/pangocairo ?

[GuillaumeGomez]

It's strangely done and outside of gtk-rs (and I didn't find the Gir.toml for the non-sys generation, seems a bit weird). Also, I think this one will be the last we'll add in gtk-rs.

[EPashkin]

We was decided that @RazrFalcon will handle this crate. It already has same fix https://github.com/RazrFalcon/pangocairo-rs/blob/master/pangocairo-sys/gir-patch.diff Strange that it don't contains Gir.toml or build script.

[EPashkin]

As I remember main reason for not including pangocairo to gtk-rs was patched .gir. See https://github.com/gtk-rs/gtk/issues/453

[RazrFalcon]

I still have no idea how gir works, but crate itself if working well. I don't know what can be changed there.

[GuillaumeGomez]

@RazrFalcon: It's mainly in order to be able to easily update by just running make gir. Also, I think it's the last piece missing and since it's not the first time someone is asking for it, we should integrate it into gtk-rs.

@EPashkin: Is it really an issue to have some .gir files patched?

[EPashkin]

For me, it almost not problem is patch applied on same script run that do download.

[GuillaumeGomez]

Great, I can do that. Just last remaining question: @RazrFalcon do you want we get your repository and clean it up so your work is kept or should I just go over with this repository?

[RazrFalcon]

@GuillaumeGomez I don't really care. I can remove this repos if there is official one. But what to do with crates itself? Can I transfer an ownership to you?

[GuillaumeGomez]

@RazrFalcon Yes you can (and thanks a lot!): http://doc.crates.io/crates-io.html#cargo-owner

[RazrFalcon]

@GuillaumeGomez can you provide a full command?

[GuillaumeGomez]

The command is the following:

cargo owner --add GuillaumeGomez

And if you want to get removed from the crate owners (but I don't mind if you remain as the second crate owner):

# /!\ be sure that you really want to not be the second crate maintainer before launching the command!
cargo owner --remove RazrFalcon

[RazrFalcon]

@GuillaumeGomez done for pangocairo and pangocairo-sys (should be removed, AFAIU).

[GuillaumeGomez]

@RazrFalcon: Thanks a lot! And no, we need the -sys crate as well. :)

[GuillaumeGomez]

Ah but you're right, we'll put it into the sys repository...

[GuillaumeGomez]

@EPashkin: Updated.

[GuillaumeGomez]

And updated again.

[EPashkin]

At minimum it compiles now, so 👍

[GuillaumeGomez]

Yeay!