Closed ximion closed 6 years ago
Thanks.
Thanks for merging! When will there be a release of GlibD? And, will GtkD use the library generated by GlibD? (The second question is useful to know whether we shoud maintain GlibD as part of the GNOME team in Debian or rather as part of the D team)
Probably soon, and yes GtkD will be using GlibD in the future.
I've tagged v2.0.0, i was trying to build GlibD on Windows using meson, but mesons D support on windows will need some work.
@MikeWey Excellent, thank you a lot!
As for D and Meson on Windows: It's technically possible, and Meson does support Windows pretty well - the D support in Meson doesn't really however, because I don't have Windows and nobody else working on the D bits in Meson it uses it as well. So, for that to be supported well, we would need someone knowledgeable in building D stuff on Windows to step up and implement the necessary bits in Meson (I guess it shouldn't be hard at all, but well, I bet as always there are some annoying things to work around - also, there is no D support in the VisualStudio Meson backend, so only when using ninja on Windows as well one has any chance to make builds work at the moment).
This patch does the following:
Lowercase pkg-config name This is a convention for pkg-config, while not really a technical requirement, it's nice to have names look uniform.
Use same naming convention for glibd as for glib itself Use the
-2.0
suffix instead of just-2
, like glib does.Use build_root variable It's available, so use it to shorten a few lines. I also made it use the current source/build directory, see the second point.
Make it easy to use glibd in a subproject The
glibd_dep
variable can be imported by other projects to easily use glibd in a subproject without relying on a copy that's installed system-wide. Instead of usingmeson.build_root()
etc. to determine the root directory, I made the code use the current directory as root. This allows usage in a subproject, because now the correct paths to the sources will be taken, instead of the root path to the main project. It's a pretty mean trap to fall in, actually.Don't mix tabs/spaces Easy :-)
Fix typo (glibd-2 instead of glib-2) In the pkg-config generation. This made tools using Makefiles/ninja not find the GLibD include directory.