search

gtkd-developers / GtkD

GtkD is a D binding and OO wrapper of GTK+ originally created by Antonio Monteiro
http://gtkd.org
Other
322 stars 71 forks source link

GApplicationFlags use FLAGS_NONE instead of NONE #197

Closed csoriano1618 closed 7 years ago

csoriano1618 commented 7 years ago

So it's inconsistent with the other flags, like GApplicationFlags.HANDLES_COMMAN_LINE which doesn't prefix the FLAGS.

MikeWey commented 7 years ago

This is how the enum is defined in the gir files, and in c it is also the only one that contains FLAGS. https://developer.gnome.org/gio/stable/GApplication.html#GApplicationFlags

Although in D you end up with ApplicationFlags.FLAGS_NONE i don't think it's worth it to add an exception to for this enum. And leave is as is the enum member names from C minus there common prefix.

csoriano1618 commented 7 years ago

I promise I triple checked :/ Not sure how I missed this... Closing