gtker / wow_messages

Auto generated messages for the World of Warcraft network protocol
Apache License 2.0
25 stars 10 forks source link

AllowedRace and AllowedClass are also considered valid for all enumerators when empty by game #56

Closed gtker closed 1 year ago

gtker commented 1 year ago

So allowed = 0 and allowed = 1 both mean that Warrior/Human are allowed to use the item.

It's counter intuitive to have to check both allowed.is_empty() && allowed.is_MY_THING() instead of just allowed.is_MY_THING().

Could possibly add a tag for flags that means that inner == 0 is also valid.