gtker / wow_messages

Auto generated messages for the World of Warcraft network protocol
Apache License 2.0
26 stars 11 forks source link

Pass dirty mask to update data setters #70

Closed Dantsz closed 1 year ago

Dantsz commented 1 year ago

Shouldn't these functions also pass the dirty mask? I get an assert failure in wrath-rs trying to update wow_messages without passing them, something about the mask size being different from the header size.

gtker commented 1 year ago

Thanks for the PR. Yes, this does seem like an oversight on my end. Any chance I could get you to add a test in this test block that errors without the fix?

gtker commented 1 year ago

Thanks, will merge when CI passes. :)