search

gtkforphp / cairo

PHP extension for Cairo Graphics Library
Other
27 stars 19 forks source link

Php7.0 fixes for Windows #27

Closed Jan-E closed 7 years ago

Jan-E commented 7 years ago

Together with https://github.com/eosforphp/datastructures/pulls this PR makes it possible to compile php_cairo.dll for PHP7.0 on Windows.

The win32 fonts and freetype fonts do not work yet.

Compilation for PHP 7.1 fails because of this issue in the dependency reported by @swen100 https://github.com/eosforphp/datastructures/issues/1

Jan-E commented 7 years ago

Added support for PHP 7.1, now that https://github.com/eosforphp/datastructures/issues/1 has been resolved. All flavours of PHP 7.1.2 RC1 with a php_cairo.dll published at https://www.apachelounge.com/viewtopic.php?t=6617

In two weeks from now, php_cairo.dll will be added to PHP 7.1.2 at https://www.apachelounge.com/viewtopic.php?t=6359

Jan-E commented 7 years ago

@auroraeosrose @swen100 Please merge this PR. I configured appveyor.yml to build all versions for PHP 7.0.18. You can download the builds through the artifacts tab of the appveyor page.

See for instance https://ci.appveyor.com/project/auroraeosrose/cairo/build/1.0.57/job/ylx335pdnpsqy001/artifacts

I did not add the tests, but this is a beginning.

swen100 commented 7 years ago

Great work @Jan-E and thanks for the compiling of the windows versions. Only Elizabeth can merge it.

Jan-E commented 7 years ago

@swen100 AppVeyor builds the PHP 7.0 versions, The PHP 7.1 ones can be found in my builds at https://www.apachelounge.com/viewtopic.php?t=6359 BTW: I do not use the extension myself with PHP 7 yet, so I am interested in your experiences.

Jan-E commented 7 years ago

@swen100 There are some remaining issues: https://github.com/gtkforphp/cairo/issues/20#issuecomment-296561224

Maybe you can pick up the work after @auroraeosrose has merged this PR

auroraeosrose commented 7 years ago

There's still some issues with this, but it's building better now so I"ll pull it