gtn / exaport

exabis eportfolio
http://www.exabis.at
13 stars 13 forks source link

Error when downloading pdf for external access #38

Open peta3000 opened 3 months ago

peta3000 commented 3 months ago

CONTEXT Moodle release version: 4.1.9 (Build: 20240212)

Plugin release version: 4.6.7 (Build: 2023091600)

PHP version: 8.1.27


Thanks a lot for maintaining and developing this plugin!!! :pray: The following issue does not seem to match any other issues already reported here.


ISSUE

After creating a view and populating it with content, when I navigate to "My views" > "Share" tab I get 4x the following debug message:

Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/lib/pear/HTML/QuickForm/checkbox.php on line 126

Screenshot from 2024-03-18 14-56-47

After enabling external access and saving I navigate to "My views".

I see the newly created view and a URL for "external access".

When I click it/open it, I am forwarded to the page: .../blocks/exaport/shared_view.php?access=hash/3-cc12f384

The browser-dev-tools-inspector console for this page also lists the following error: Uncaught ReferenceError: JQuerryExaport is not defined Screenshot from 2024-03-18 15-39-20

When clicking the mentioned hyperlink:


OTEHR OBSERVATIONS reg. block_exaport

When running local_codechecker https://moodle.org/plugins/local_codechecker against blocks/exaport I get in total: 2567 errors and 2402 warnings

Please have a look into Moodle's coding syle guide: https://moodledev.io/general/development/policies/codingstyle

e.g. Code repository name https://moodledev.io/general/community/plugincontribution/checklist#code-repository-name should be moodle-{plugintype}_{pluginname}


Many thanks and best regards

Peter