search

gtorrent / gtorrent-core

Core library of gTorrent which handles everything but UI/UX
GNU General Public License v3.0
39 stars 12 forks source link

Proper solution to problem fixed in https://github.com/gtorrent/gtorrent-core/pull/96 #101

Closed shinigamichan closed 9 years ago

shinigamichan commented 9 years ago

Please test on linux/older version of libtorrent before merging.

fuyukaidesu commented 9 years ago

Saner and this one works on windows.

fuyukaidesu commented 9 years ago

Nah actually doesn't work in windows. And we use a lot of things that are deprecated in SVN, so getting this little method to work across the two version shouldn't be a priority.

Will be removed in a future merge to make the thing really crossplatform.

shinigamichan commented 9 years ago

Fuyukaidesu, both methods work in Windows for me, Windows core gt::Platform is currently fucked up regarding the makeSharedFile function though, causing an immediate crash due to unhandled exception. It compiles though. Maybe your compiler doesn't properly support decltype, which is c++11? I know we were already using c++11 features at least in gtorrent-legacy and gtorrent-gtk, but maybe not in core.

Plus libtorrent-rasterbar 1.01 is now release and not svn, so it's necessary to support it. And it should be a priority because depreciated doesn't mean incompatible. If anything we'd change to only supporting 1.01 but it's easy to support both this way.

In fact I've been developing and testing exclusively on Windows, that's why the original post says to test on Linux.

fuyukaidesu commented 9 years ago

I'm compiling on VS with msvc 110, it supports decltype and __typeof, but not the same way you're using.