boost::int64_t -> int64_t

[fuyukaidesu]

Ever heard of long ?

[benwaffle]

Ever heard of portability?

[fuyukaidesu]

Exactly ? The standard says these typedefs don't have to be defined. Also >talking about portability >in gtorrent

[fuyukaidesu]

>merged

whats the point of a PR if others don't review it

--ben

[benwaffle]

• minor changes
• you've seen it
• it built in travis
• it works with gt-gtk

[benwaffle]

The standard says these typedefs don't have to be defined.

Even if that's true, the problem persists since boost uses those.

[nyanpasu]

minor changes you've seen it it built in travis it works with gt-gtk

I wonder who thought up of the "Three devs approval minimum" rule.

[benwaffle]

it was 2, no one follows it, and no one likes it

would you prefer that we started following it?

[shinigamichan]

Libtorrent internally uses libtorrent::size_type, defined in libtorrent/size_type.hpp for the return types of those functions, using a typedef to define this as boost::int64_t so getting rid of it just adds a slight overhead to convert and does nothing to reduce boost dependencies.

What we really should be doing is including it and using libtorrent::size_type itself, which is what I believe I suggested a while ago when someone was working on the code to display and format this since there was an overflow issue, but it was misinterpreted as directly use boost::int64_t.

[benwaffle]

ok