search

gtorrent / gtorrent-core

Core library of gTorrent which handles everything but UI/UX
GNU General Public License v3.0
39 stars 12 forks source link

Remove log #19

Closed fuyukaidesu closed 10 years ago

fuyukaidesu commented 10 years ago

Issue by CrimsonVoid Wednesday Jul 16, 2014 at 22:40 GMT Originally opened as https://github.com/gtorrent/gTorrent-legacy/issues/51

IMO logging isn't something a torrent client should implement. I would recommend either using an existing library like boost.log or moving it to another package.

fuyukaidesu commented 10 years ago

Comment by infoburp Wednesday Jul 16, 2014 at 23:11 GMT

could be optional

fuyukaidesu commented 10 years ago

Comment by nyanpasu Thursday Jul 17, 2014 at 10:28 GMT

:+1:

I support removing it from the present build, since at the moment is serves nothing helpful. Alternatively, we could set a DEBUG flag in CMake that defines HAVE_DEBUG or something that will enable verbosity throughout the program.

fuyukaidesu commented 10 years ago

Comment by truNEET Thursday Jul 17, 2014 at 13:49 GMT

Either that, or a [ --verbose, -v ] style command line argument.

fuyukaidesu commented 10 years ago

Comment by infoburp Thursday Jul 17, 2014 at 23:26 GMT

+1 for -v argument