Configuration file - Githubissues

gtorrent / gtorrent-core

Core library of gTorrent which handles everything but UI/UX

GNU General Public License v3.0

39 stars 12 forks source link

Configuration file #20

Closed fuyukaidesu closed 10 years ago

fuyukaidesu commented 10 years ago

Issue by nyanpasu Thursday Jul 17, 2014 at 14:17 GMT Originally opened as https://github.com/gtorrent/gTorrent-legacy/issues/59

fuyukaidesu commented 10 years ago

Comment by truNEET Thursday Jul 17, 2014 at 14:21 GMT

Yes, what do you guys think? JSON file? Simple key=value? Maybe a custom format with a few additional options?

Regardless of the implementation, I think we should have one class/utility that reads the command line arguments and parses the settings file that we can query anywhere in the application.

fuyukaidesu commented 10 years ago

Comment by nyanpasu Thursday Jul 17, 2014 at 14:23 GMT

I like the idea of a simple parser that reads key = value.

Easy to implement
Very hard to fuck up
Simple comments (# maybe)
Disregards unrelated keys, maybe complain in --verbose mode

Reasons I don't like:

XML
- Unreadable, even if they like to call it "human readable" lel
- Hard to configure by hand
- Fucking. Ugly.
JSON
- javascript
- Fucking. Ugly.

Mostly because they require silly syntax rules.

fuyukaidesu commented 10 years ago

Comment by truNEET Thursday Jul 17, 2014 at 14:27 GMT

Reasons I don't like XML

Yes, XML fucking sucks and we should avoid it at all costs for configuration files.

fuyukaidesu commented 10 years ago

Comment by nyanpasu Thursday Jul 17, 2014 at 14:28 GMT

Some retards on IRC and /g/ actually suggested that. I cringe when it's on a configuration file that the developers expect you to actually maintain and edit. I would not want to inflict that sort of punishment towards anyone.

fuyukaidesu commented 10 years ago

Comment by Madotsukii Thursday Jul 17, 2014 at 23:43 GMT

Maybe just good old-fashioned .ini?