gtorrent / gtorrent-core

Core library of gTorrent which handles everything but UI/UX
GNU General Public License v3.0
39 stars 12 forks source link

Removing gtorrent-core #86

Closed AndrewBerry closed 9 years ago

AndrewBerry commented 9 years ago

This is a legitimate post.

gtorrent-core is a formatting layer and that's about it. Most of the code that isn't remapping the libtorrent api is for features like file association, string formatting and core related setting files.. all of which are UI/UX related and should be client based code.

Why restrict the GUI developers by having them map libtorrent API calls from gtorrent-core then send a PR? Instead of poking holes in the wall when necessary just remove the whole damn wall.

I propose we remove the entire gtorrent-core code base and shift the scope of the gtorrent project to focus on the GUI development of gtorrent, using libtorrent directly. The whole purpose of this project was to create a torrent client that was lightweight and not bloated with adware, or, the utorrent killer.

I've spoken to fuyukaidesu on #gtorrent about this and he couldn't come up with any real reasons to keep gtorrent-core other than it being bothersome to switch the gtk branch over to using pure libtorrent.

benwaffle commented 9 years ago

Perhaps instead of rewriting each UI, why not work on moving functionality from gt-gtk to gt-core?

fuyukaidesu commented 9 years ago

he couldn't come up with any real reasons

You couldn't agree with any of my reasons*

If you want to make -gtk without core, go ahead, but let me remind you that you're with every developer that wants to remove core, aka alone.

Why restrict the GUI developers by having them map libtorrent API

They'll just have a normal unrelated client if they develop their own gui on top of libtorrent ?