unit tests with googletest

[benwaffle]

Of course this will need better integration with CMake and travis

[nyanpasu]

Wish you'd split up the commit containing 'a simple test case' for just our repo separately so that I don't have to look through a 100k diff to find what I'm looking for.

[fuyukaidesu]

One hundred thousands lines of code to test if the magnet method returns true if the argument passed is "magnet".

what is assert

If you seriously want something like this to be merged, you'll need to write more complete tests.

[benwaffle]

Obviously thats planned

[fuyukaidesu]

Why make a PR then.

[zovt]

Is there a reason that you didn't use a submodule for googletests?

[benwaffle]

It's not hosted on github We could though

[zovt]

There is one hosted here, but it was last updated ~3 years ago, whereas the latest release on their official repo is from 2013. I'm going to do some looking around to see if we can add an svn submodule

[zovt]

http://stackoverflow.com/questions/465042/is-it-possible-to-have-a-subversion-repository-as-a-git-submodule

I suppose if we had to we could mirror their SVN repo ourselves. If anyone has a better solution, please do post

[fuyukaidesu]

The better solution would be to not use unit tests if no one knows how it works.

[benwaffle]

It easy to write, see main.cpp. And we'll just upload a copy of googletest to a new repo.

[fuyukaidesu]

You're going to need a more sophisticated example than main.cpp because assert can do very well the same thing without pulling a 100KLOC framework.

[benwaffle]

It has pretty output and details what goes wrong. Plus it has stuff like fixtures and other unit testing components

[fuyukaidesu]

Wowow only 100 files and 100kloc for colored output. Impressive.

No, seriously, go write all of the required unit test, because right now the merge is completely useless.