search

gtorrent / gtorrent-gtk

Gtk client built on gtorrent-core
GNU General Public License v3.0
30 stars 9 forks source link

default column widths #71

Closed benwaffle closed 10 years ago

nyanpasu commented 10 years ago

My suggestion would be to retrieve the last used widths of columns when gtorrent last closed gracefully.

(I mean if you're going to make the program use default widths, might as well make it do it properly the first time.)

fuyukaidesu commented 10 years ago

@nyanpasu I-I'm already working on that on my ui-fixes branch...

benwaffle commented 10 years ago

Idk about C++, but use something like Optional in Java Then we can do Settings::get("#-col-width").orElse(20) which should return the setting or 20 if it has not be set yet

nyanpasu commented 10 years ago

w, our Settings.cpp does that. You just need to set up #-col-width" first.

Could you work directly on @fuyukaidesu's branch? She probably already worked on part of it.

fuyukaidesu commented 10 years ago

I really was just about doing it, I just made a few ui fixes on my branch, and planned to do this right now. Basically a setting for each columns, if it's enabled, and their width. I just don't really like how this will add 2 lines per column in the config file.

I'll push my last changes on my branch.

nyanpasu commented 10 years ago

I think it shouldn't go into the config file. I doubt anyone actually cares enough to set up the default widths of their columns. In any case, it's probably more appropriate to implement it as part of session data.