search

gtorrent / gtorrent-gtk

Gtk client built on gtorrent-core
GNU General Public License v3.0
30 stars 9 forks source link

Wip/hide actionless buttons #82

Closed infoburp closed 10 years ago

infoburp commented 10 years ago

I've based this on the principle of least astonishment.

We might want the pause/remove buttons to have action on all torrents when none is selected, however this warrants further thought/discussion, and I think this is a good solution for the interim.

fuyukaidesu commented 10 years ago

Yeah huh. What is this supposed to do ? Edit: nvm got it.

infoburp commented 10 years ago

When no torrent is selected, it hides the remove/pause buttons, also the properties button is commented out, because it never does anything.

fuyukaidesu commented 10 years ago

The properties button is just a placeholder that is supposed to be implemented soon, if it bothers you that it doesn't do anything, implement its functionality or don't touch it.

fuyukaidesu commented 10 years ago

If you want to hide the remove button, let me doing, I'll clean up a bit of code btw.

infoburp commented 10 years ago

ok well I'll leave this up for now and close it when appropriate.

regarding the properties button, rather than having this at all, isn't the obvious thing to do to have per torrent properties in the bottom pane next to the graph/info?

I'll work on making the pause/remove buttons work for all torrents when none is selected (with confirmation dialog for remove).

fuyukaidesu commented 10 years ago

regarding the properties button, rather than having this at all, isn't the obvious thing to do to have per torrent properties in the bottom pane next to the graph/info

Isn't the obvious thing to separate the torrent specific information and the torrent specific settings ?

pause/remove buttons work for all torrents when none is selected

That's dum.

infoburp commented 10 years ago

I'm not sure, I think having the settings in the bottom pane would be fine, personally. I'd be interested to know what the other devs think.

I make 2 assumptions:

That the user might want to pause or remove all torrents.

That this is the most obvious way of doing this.

Of course I welcome any comments on this, other ways to implement pause/remove all, or is such a function not even desirable? If not, why not?