Closed IGI-111 closed 10 years ago
It works correctly in my wip/ui-rewrite branch, probably because resources are embedded into the executable.
That's probably it then, it'll get fixed when wip/ui-rewrite is merged. Shall we close it now or wait until master is fine?
@infoburp
That's probably it then, it'll get fixed when wip/ui-rewrite is merged. Shall we close it now or wait until master is fine?
It's a known issue. We'll leave it open anyway.
I think it's best to leave open for now, @nyanpasu . I am now aware that it has been fixed in ui-rewrite though, that's great :)
How close is that to being ready to merge into master, @fuyukaidesu ?
Really far away. It's so different from the master branch I guess we just started basing all our work on it. fuyukaidesu stopped "rewriting the ui" and just went straight to implementing RSS dialogs on ui/rewrite
Oh dear, this isn't good, is there any way we could make a stable version of ui-rewrite, then merge that down before you drift too much further away from master?
PS: I'm happy to put in a few hours this weekend + possibly Monday to get this done but I've got uni the rest of the week so I might not have much time.
No. Let's just merge it now. (It's not like we have a team of lunatics who'd chew us out for it. It's stable enough.)
Make it so.
As @nyanpasu said, it's pretty stable, I haven't got a crash in 3 days, but as of right now, ui-rewrite relies on wip/rss, there's still a few things that needs to be done for the RSS dialog, the side bar, and implement labels before merging it into master.
But if we don't really care about master to have incomplete features, I can make a PR.
@fuyukaidesu ww, I already merged it in.
Edit: gomen.
Oops. just noticed.
After installing gtorrent, the version in PATH crashes on start, probably due to missing dependencies.