Editor is crashing

[gtrafimenkov]

When launching with JA2-vanilla.exe -EDITOR after the intro application is crashing.

[gtrafimenkov]

Crash in the debugger:

[gtrafimenkov]

The app crashes because:

• CreateEasyToggleButton(134, 434, "EDITOR//... returns -1, the value is not checked
• then ButtonList[-1] is accessed to write some data to it
• that corrupts the memory
• CreateEasyToggleButton returns -1 because the requested image cannot be found; it cannot be found because it should be loaded from editor.slf, but it is not in the hardcoded list of supported libraries

editor.slf is not here:

LibraryInitHeader gGameLibaries[] = {
    // Library Name                 Can be  Init at start
    //                                                  on
    // cd
    {"Data.slf", FALSE, TRUE},
    {"Ambient.slf", FALSE, TRUE},
    {"Anims.slf", FALSE, TRUE},
    {"BattleSnds.slf", FALSE, TRUE},
    {"BigItems.slf", FALSE, TRUE},
    {"BinaryData.slf", FALSE, TRUE},
    {"Cursors.slf", FALSE, TRUE},
    {"Faces.slf", FALSE, TRUE},
    {"Fonts.slf", FALSE, TRUE},
    {"Interface.slf", FALSE, TRUE},
    {"Laptop.slf", FALSE, TRUE},
    {"Maps.slf", TRUE, TRUE},
    {"MercEdt.slf", FALSE, TRUE},
    {"Music.slf", TRUE, TRUE},
    {"Npc_Speech.slf", TRUE, TRUE},
    {"NpcData.slf", FALSE, TRUE},
    {"RadarMaps.slf", FALSE, TRUE},
    {"Sounds.slf", FALSE, TRUE},
    {"Speech.slf", TRUE, TRUE},
    //  { "TileCache.slf",              FALSE, TRUE },
    {"TileSets.slf", TRUE, TRUE},
    {"LoadScreens.slf", TRUE, TRUE},
    {"Intro.slf", TRUE, TRUE},

#ifdef JA2DEMO
    {"DemoAds.slf", FALSE, TRUE},
#endif

#ifdef GERMAN
    {"German.slf", FALSE, TRUE},
#endif

#ifdef POLISH
    {"Polish.slf", FALSE, TRUE},
#endif

#ifdef DUTCH
    {"Dutch.slf", FALSE, TRUE},
#endif

#ifdef ITALIAN
    {"Italian.slf", FALSE, TRUE},
#endif

#ifdef RUSSIAN
    {"Russian.slf", FALSE, TRUE},
#endif

};

So, there are few issues with this code:

• errors are not checked (-1 returned from CreateEasyToggleButton)
• hardcoded list of libraries that is missing editor slf