Fixed crash that could occur when only resizing the Sub Band Size

gtreshchev / AudioAnalysisTools

Audio Analysis Tools plugin for Unreal Engine. Provides a variety of functions for analyzing audio data. Works in conjunction with the Runtime Audio Importer plugin.

MIT License

92 stars 16 forks source link

Fixed crash that could occur when only resizing the Sub Band Size #4

Closed Caffiendish closed 2 years ago

Caffiendish commented 2 years ago

Also added in checks for resizing the FFTSubbandsSize and EnergyHistorySize, removed a call to the UpdateEnergyHistorySize in the CreateBeatDetection function, replaced with updating the EnergyHistorySize directly; we immediately call a function that calls the UpdateEnergyHistorySize

gtreshchev commented 2 years ago

It was a bug, thanks for reporting and pull request! I only noticed minor stuff that would probably look better if changed a bit.

Caffiendish commented 2 years ago

Updated as per feedback; good points, wasn't clear what was/wasn't happening.