search

gtrevg / fluent-plugin-splunk-ex

A fluentd plugin that can push data to splunk in either key=value or JSON format. Also supports reconnects on broken connections.
11 stars 9 forks source link

Bumping fluentd dependency to get rid of issue with msgpack #6

Closed jmcshane closed 5 years ago

jmcshane commented 5 years ago

Fixes #5

The old fluentd dependency did not have support for ruby 2.5

@gtrevg would you be able to build a new version with this new dependency?

gtrevg commented 5 years ago

It's been forever since I've done this...

host:~/.../github.com/jmcshane/fluent-plugin-splunk-ex [master] $ /opt/td-agent/usr/sbin/td-agent-gem build fluent-plugin-splunk-ex.gemspec 
WARN: Unresolved specs during Gem::Specification.reset:
      msgpack (< 2, >= 0.5.11)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
WARNING:  description and summary are identical
WARNING:  open-ended dependency on json (>= 0) is not recommended
  if json is semantically versioned, use:
    add_runtime_dependency 'json', '~> 0'
WARNING:  open-ended dependency on rake (>= 0, development) is not recommended
  if rake is semantically versioned, use:
    add_development_dependency 'rake', '~> 0'
WARNING:  open-ended dependency on rspec (>= 0, development) is not recommended
  if rspec is semantically versioned, use:
    add_development_dependency 'rspec', '~> 0'
WARNING:  open-ended dependency on pry (>= 0, development) is not recommended
  if pry is semantically versioned, use:
    add_development_dependency 'pry', '~> 0'
WARNING:  open-ended dependency on pry-nav (>= 0, development) is not recommended
  if pry-nav is semantically versioned, use:
    add_development_dependency 'pry-nav', '~> 0'
WARNING:  See http://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: fluent-plugin-splunk-ex
  Version: 1.0.3
  File: fluent-plugin-splunk-ex-1.0.3.gem
host:~/.../github.com/jmcshane/fluent-plugin-splunk-ex [master] $ /opt/td-agent/usr/sbin/td-agent-gem install fluent-plugin-splunk-ex-1.0.3.gem
WARN: Unresolved specs during Gem::Specification.reset:
      msgpack (< 2, >= 0.5.11)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
Successfully installed fluent-plugin-splunk-ex-1.0.3
Parsing documentation for fluent-plugin-splunk-ex-1.0.3
Installing ri documentation for fluent-plugin-splunk-ex-1.0.3
Done installing documentation for fluent-plugin-splunk-ex after 0 seconds
1 gem installed

@jmcshane Let me know if this ^^ is what you expected to see on a build/install.

I've tagged the repo with proper version numbers, so that should allow anyone to pull a specific version (v0.0.1, v1.0.0, v1.0.1). This merge will be v1.0.3.

jmcshane commented 5 years ago

LGTM, I didn't clean up any of those dev dependency warnings, but upgrading the fluentd gem should be enough to resolve the issues.

Thanks for your help, I realize this hasn't been updated since 2014, so I appreciate you getting back to me quickly!

gtrevg commented 5 years ago

@jmcshane Merged and tagged v1.0.3

jmcshane commented 5 years ago

@gtrevg Can you push this version to rubygems.org?