search

gts-morpher / gts_morpher

Tool for building GTS Morphisms and Amalgamations
MIT License
4 stars 0 forks source link

repeated ids #27

Closed narudocap closed 4 years ago

narudocap commented 4 years ago

Node identifiers are not correctly renames when collided. In the attached example, two Observer objects are added (of qualified classes leftObserver and rightObserver), but their ids are not changed (both o).

pls_repeated_ids_bug.zip image

szschaler commented 4 years ago

I suspect this is a duplicate of #28, but need to check to confirm.

narudocap commented 4 years ago

Possibly, it looks like ids and types are not handled in the same way though.

szschaler commented 4 years ago

Yes. Naming happens through the naming strategies throughout. However, I need to check what uniqueness contexts are provided and whether they're adequate here.

szschaler commented 4 years ago

This project demonstrates another issue: because one of the mappings is already a complete morphism, we issue a warning against auto-complete. This, in turn, however, prevents the generator-based composition from running. It appears, however, that the normal composition does run.

szschaler commented 4 years ago

Turns out node naming wasn't correctly implemented after all: I had forgotten to define a suitable uniqueness context. Fixed now.