gts-morpher / gts_morpher

Tool for building GTS Morphisms and Amalgamations
MIT License
4 stars 0 forks source link

Rule-parameter mappings #36

Closed szschaler closed 4 years ago

szschaler commented 4 years ago

Allow rule parameters to be explicitly mapped and woven. Resolves #22.

Tasks

szschaler commented 4 years ago

@narudocap can you have a play with this and provide feedback via the Github review mechanism?

narudocap commented 4 years ago

I've created a simple example (pls v12) but doesn't seem to work, could you check whether it's a problem in the implementation or in the example? Perhaps it is not what I should be testing. A description is in the README file. https://github.com/gts-morpher/pls/tree/master/pls12

szschaler commented 4 years ago

There were some typos in the assemble rule. I've just committed a fix. Now there are no problems and parameters seem to be woven correctly.

narudocap commented 4 years ago

Here is an additional test case with different combinations of parameters: https://github.com/gts-morpher/pls/tree/master/pls13

szschaler commented 4 years ago

This one is interesting as it exposes a remaining issue with name uniqueness. I think this is related to #41 .