search

gtsteffaniak / filebrowser

📂 Web File Browser
Apache License 2.0
19 stars 1 forks source link

Remove redundant calls to baseURL/url #23

Closed gtsteffaniak closed 1 year ago

gtsteffaniak commented 1 year ago

Clone from https://github.com/filebrowser/filebrowser/pull/2579

There is an issue where ${baseURL} may be called twice when uploading through tus.

The scenario can be reproduced as follows:

Run ./filebrowser --baseUrl baseUrl When attempting to upload, a 404 error occurs as the POST request is invoked with baseUrl/url/baseUrl/url However, there is no redundant call in the subsequent HEAD request This seems to happen because, as the const tusEndpoint of constants.js is transferred to the fetchURL of utils.js, the predefined baseURL is added once more to the fetch

To resolve this, the baseURL is removed before calling fetchURL if it already exists.

For more details, please refer to the following issue. (https://github.com/filebrowser/filebrowser/issues/2581)

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.