sanak
commented
4 months ago The routing error cause seems to be redirecting to /custom_fields_groups with PUT method, and Redmine core, GTT and TextBlocks plugins seem to avoid it by separating format response between html and js for both manual and position (*.erb.js) update in those controllers.
So, I will apply similar changes for this, later.
* Redmine 5.1: https://github.com/redmine/redmine/blob/5.1-stable/app/controllers/custom_fields_controller.rb#L66-L80
```rb
if @custom_field.save
call_hook(:controller_custom_fields_edit_after_save, :params => params, :custom_field => @custom_field)
respond_to do |format|
format.html do
flash[:notice] = l(:notice_successful_update)
redirect_back_or_default edit_custom_field_path(@custom_field)
end
format.js {head 200}
end
else
respond_to do |format|
format.html {render :action => 'edit'}
format.js {head 422}
end
end
```
* GTT plugin: https://github.com/gtt-project/redmine_gtt/blob/main/app/controllers/gtt_map_layers_controller.rb#L33-L49
```rb
if r.map_layer_updated?
respond_to do |format|
format.html {
flash[:notice] = l(:notice_successful_update)
redirect_to gtt_map_layers_path
}
format.js { head 200 }
end
else
respond_to do |format|
format.html {
@map_layer = r.map_layer
render 'edit'
}
format.js { head 422 }
end
end
```
* TextBlocks plugin: https://github.com/gtt-project/redmine_text_blocks/blob/main/app/controllers/text_blocks_controller.rb#L42-L57
```rb
if r.text_block_saved?
respond_to do |format|
format.html {
flash[:notice] = l(:notice_successful_update)
redirect_to index_path
}
format.js { head 200 }
end
else
respond_to do |format|
format.html {
render 'edit'
}
format.js { head 422 }
end
end
```
Problem Reordering custom_fields_groups item by drag&drop causes 404 routing error ,
and doesn'talthough reordering itself is done successfully after browser reload.To Reproduce
/custom_fields_groupsview.Expectation Routing error should not be happen and order is changed.