gtt-project / redmine_custom_fields_groups

Redmine plugin for grouping custom fields.
GNU General Public License v3.0
12 stars 5 forks source link

Plugin setting typo in "fieldset_default_state" key's "all_expended" value #27

Open sanak opened 5 months ago

sanak commented 5 months ago

Problem This is similar with Redmine core side typo.

Expectation all_expended should be replaced to all_expanded.

Note Consider to add migration process in settings and user_preferences tables. Here is the code snippet of settings table value.

setting = Setting.plugin_redmine_custom_fields_groups
if (
  setting.present? &&
  setting.has_key?('fieldset_default_state') &&
  setting['fieldset_default_state'] == 'all_expended'
)
  setting['fieldset_default_state'] = 'all_expanded'
  Setting.plugin_redmine_custom_fields_groups = setting
end