Feature/configurable before after attachment category

gtt-project / redmine_gtt_print

Plugin to add printing (with maps) to GTT

GNU General Public License v3.0

1 stars 2 forks source link

Feature/configurable before after attachment category #15

Closed sanak closed 2 years ago

sanak commented 2 years ago

Supports #14.

~~NOTE: PR target is 0.1-stable branch to support existing customer.~~

Changes proposed in this pull request:

Revert "Simplified image urls":
- commit diff: https://github.com/gtt-project/redmine_gtt_print/commit/911fe8d2d39d92e928a1777624d257e5753e8073
Switched attachment logic plugin
Supported both installed and not installed attachment_categories plugin cases
Configurable attachment before/after tag

@gtt-project/maintainer

sanak commented 2 years ago

@dkastl @mopinfish
Merge target branch may change from 0.1-stable to 1.0-stable, due to #10 which I reopened, but this is ready for merge.

I confirmed that RAILS_ENV=test bundle exec rake redmine:plugins:test NAME=redmine_gtt_print passed and actual printing works correctly on both installed and uninstalled redmine_attachment_categories plugin environment. (NOTE: During above test, there were warnings which comes from ruby 2.7.5 environment, but I will create/fix those on another issue/PR.)

sanak commented 2 years ago

Related with #10, I upgrade version and adjusted name, then change target branch from 0.1-stable to main.

sanak commented 2 years ago

@dkastl @mopinfish Well, to check Redmine 5.0 upgrade, I will merge this PR to 1.1-stable branch, once.