search

guacsec / guac-docs

Docs to ingest in GUAC
https://guac.sh/
Creative Commons Attribution 4.0 International
8 stars 30 forks source link

Document the ClearlyDefined certifier #167

Closed Ritesh-Udgata closed 2 weeks ago

Ritesh-Udgata commented 2 weeks ago

Closes #131

netlify[bot] commented 2 weeks ago

Deploy Preview for resonant-wisp-1a517a ready!

Name Link
Latest commit ae055bb8886808dbbdc75bdb7b96851bca69f014
Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/6723db76f67d0d0008e579d3
Deploy Preview https://deploy-preview-167--resonant-wisp-1a517a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Ritesh-Udgata commented 2 weeks ago
  1. Added link to configuration guide
  2. Added table of supported command line argument.
  3. Changed Title
  4. Link to clearlydefined.io
  5. Removed official doc link
  6. Added third option to integrate ClearlyDefined into Guac
  7. Formatted document using Prettier
  8. committed along with signoff and gpg-sign
Ritesh-Udgata commented 2 weeks ago

DONE 👍

Ritesh-Udgata commented 2 weeks ago
  1. Ran through Prettier. Came out exactly the same.
  2. Squashed all commits into the initial commit. Kept the commit message same as initial commit.
  3. Added sign off and gpg-key
  4. force pushed the branch
funnelfiasco commented 2 weeks ago

Ran through Prettier. Came out exactly the same.

It shouldn't have. Prettier will wrap lines at 80 characters if you use npx --yes prettier --write --prose-wrap always *.md, which is what the CI build (which just failed) does. Looking at your file, there are still several lines longer than 80 characters

Ritesh-Udgata commented 2 weeks ago
  1. Used prettier command
  2. added sign off and gpg sign
  3. rebased again and squashed all commit
  4. forced push the branch