search

guacsec / guac

GUAC aggregates software security metadata into a high fidelity graph database.
https://guac.sh
Apache License 2.0
1.29k stars 179 forks source link

[feature] Azure Blob Storage collector #1320

Open ridhoq opened 1 year ago

ridhoq commented 1 year ago

Similar to #1020 and the GCS collector, guac can collect from Azure Blob Storage

Describe the solution you'd like There can be an integration into Azure Event Grid to notify guac of a new blob creation event to go trigger a collection.

naveensrinivasan commented 1 year ago

Why not have a generic solution with https://github.com/google/go-cloud?

ridhoq commented 1 year ago

Why not have a generic solution with https://github.com/google/go-cloud?

@naveensrinivasan Are you asking if we should have a generic blob storage collector? Theoretically, it makes sense but my concern would be that not all implementations in go-cloud are equivalent.

An incremental approach could be:

  1. Build Azure Blob Storage collector
  2. Build cloud agnostic blob collector
  3. Deprecate all of the other collectors when there's confirmation that all (S3, GSC, AzBlob) are all at parity with cloud agnostic.
lumjjb commented 1 year ago

I like the incremental approach! I think both a go-cloud and individual collector implementations can co-exist.

pxp928 commented 1 year ago

+1 on the incremental approach