search

guacsec / guac

GUAC aggregates software security metadata into a high fidelity graph database.
https://guac.sh
Apache License 2.0
1.29k stars 176 forks source link

Parser tests should check for calls to GetIdentities too #136

Open lumjjb opened 2 years ago

lumjjb commented 2 years ago

Currently parser tests do not test for GetIdentities (in pkg/ingestor/parser)

ankitm123 commented 2 years ago

I would be interested to work on this, if no one else has started working on it. cc @lumjjb

pxp928 commented 1 year ago

Sorry missed this message but yes @ankitm123 you can work on this. Thanks!

lumjjb commented 1 year ago

Hi @ankitm123 ! are you still looking into this issue?

stevemenezes commented 1 year ago

Is this issue resolved by adding this or we want to incorporate additional testing?

pxp928 commented 1 year ago

Hello @stevemenezes, the thought process here was to get unit tests for each implementation (for example SPDX) https://github.com/guacsec/guac/blob/d29cbb83a14eeeef5daa108f8b7d6779c4c85086/pkg/ingestor/parser/spdx/parse_spdx.go#L313-L315

Currently, we are not using, GetIdentities but is high on the priority list to get started.

rakshitgondwal commented 6 months ago

Hi @lumjjb @pxp928! I'd like to work on this.

pxp928 commented 6 months ago

GetIdentities is still not implemented yet. So nothing to be done at this point.