search

guacsec / guac

GUAC aggregates software security metadata into a high fidelity graph database.
https://guac.sh
Apache License 2.0
1.29k stars 176 forks source link

Increase golanglint CI timeout #163

Closed lumjjb closed 2 years ago

lumjjb commented 2 years ago

Golang lint CI seems to timeout sometimes.. We should increase the timeout threshold!

https://github.com/guacsec/guac/blob/main/.github/workflows/ci.yaml#L90

krishnaindani commented 2 years ago

hey, could I work on this?

lumjjb commented 2 years ago

Go for it!!! 😄 I'll assign you!

On Wed, Oct 19, 2022, 12:20 AM Krishna Indani @.***> wrote:

hey, could I work on this?

— Reply to this email directly, view it on GitHub https://github.com/guacsec/guac/issues/163#issuecomment-1283403244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXLDBQRVZ2YHDUAWJATVSTWD5ZH5ANCNFSM6AAAAAARIPEMLA . You are receiving this because you authored the thread.Message ID: @.***>

krishnaindani commented 2 years ago

thank you, I will start working on this

Siddhant-K-code commented 2 years ago

Currently golanglint usually takes ~57000ms . For the safer side, we can set the timeout limit to 60000ms. This could be an easy quick fix.

Proposed solution:

run:
  timeout: 2m

Note: 2 minutes to be on the safer side. other examples: 30s, 5m, default is 1m

run:
  timeout: 2m
  concurrency: 4

I can send out the PR.

lumjjb commented 2 years ago

Sounds good to me 2 minute seems like plenty of time!

On Sat, Oct 22, 2022, 11:56 PM Siddhant Khare @.***> wrote:

Currently golanglint usually takes ~57000ms https://github.com/guacsec/guac/actions/runs/3301617490/jobs/5447291798#step:6:29. For the safer side, we can set the timeout limit to 60000ms. This could be an easy quick fix.

Proposed solution:

  • Introducing a new file .golangci.yaml in root of the repository.
  • file content:

run: timeout: 2m

Note: 2 minutes to be on the safer side.

I can send out the PR.

— Reply to this email directly, view it on GitHub https://github.com/guacsec/guac/issues/163#issuecomment-1287997426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXLDBTFRBIBT2TIK4SJE73WESZNNANCNFSM6AAAAAARIPEMLA . You are receiving this because you authored the thread.Message ID: @.***>

mihaimaruseac commented 2 years ago

Fixed by #181

Siddhant-K-code commented 2 years ago

Thanks @krishnaindani for raising out the PR 🙌🏼

mihaimaruseac commented 2 years ago

It's @krishnaindani who did the work, thank you @krishnaindani