Closed mrizzi closed 1 month ago
Describe the bug In PR-2164 the test has been changed to expect both Inline and ListVersion but this would cause the Both Inline and ListVersion are provided error during ingestion because of failure in validating license in: https://github.com/guacsec/guac/blob/f13bed16fc13607ced4269e5ff5b1ae13f48c9ec/pkg/assembler/graphql/resolvers/validation.go#L143
Inline
ListVersion
Both Inline and ListVersion are provided
To Reproduce Basically the test's expectation is wrong so reverting it to not expect ListVersion: ptrfrom.String("1.2.3") would reproduce the issue.
ListVersion: ptrfrom.String("1.2.3")
Expected behavior Not having a value for ListVersion field when Inline has a value
GUAC version Current main branch, i.e. f13bed16fc13607ced4269e5ff5b1ae13f48c9ec
main
Ingested document(s)
SPDX with custom licenses test
SPDX with custom licenses
Additional context
ah good catch @mrizzi!
Describe the bug In PR-2164 the test has been changed to expect both
Inline
andListVersion
but this would cause theBoth Inline and ListVersion are provided
error during ingestion because of failure in validating license in: https://github.com/guacsec/guac/blob/f13bed16fc13607ced4269e5ff5b1ae13f48c9ec/pkg/assembler/graphql/resolvers/validation.go#L143To Reproduce Basically the test's expectation is wrong so reverting it to not expect
ListVersion: ptrfrom.String("1.2.3")
would reproduce the issue.Expected behavior Not having a value for
ListVersion
field whenInline
has a valueGUAC version Current
main
branch, i.e. f13bed16fc13607ced4269e5ff5b1ae13f48c9ecIngested document(s)
SPDX with custom licenses
testAdditional context