robert-cronin commented 1 week ago

Description of the PR

Fixes #1616

PR Checklist

[x] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[x] All new changes are covered by tests
[ ] If GraphQL schema is changed, make generate has been run
[ ] If GraphQL schema is changed, GraphQL client updates/additions have been made
[ ] If OpenAPI spec is changed, make generate has been run
[ ] If ent schema is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

lumjjb commented 1 week ago

@robert-cronin can you rebase, which should fix the ci errors. thanks!

robert-cronin commented 4 days ago

Added some changes to the test suite in order to allow registering the same collector again for each case. cc @pxp928 @lumjjb