search

guagua-pamcn / a-dda

Automatically exported from code.google.com/p/a-dda
0 stars 0 forks source link

updsvnrev.sh is not fully portable #172

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The script updsvnrev.sh, which detects the current revision number fails on 
systems, where sh doesn't point to bash (like Ubuntu). The problem is that the 
script is called from Makefile using 'sh ...' (for compatibility with Windows 
with MinGW), ignoring the shebang in the script itself. Therefore, there is no 
simple way to specify that the script should be processed with bash.

This is not critical, since the compilation continues without the revision 
number. The possible solution is to replace all bash extensions in the script 
(not that much) by POSIX-compliant code.

Original issue reported on code.google.com by yurkin on 22 Aug 2013 at 9:17

GoogleCodeExporter commented 8 years ago 
The attached file is proposed as fix, please verify on Ubuntu.

Original comment by yurkin on 22 Aug 2013 at 9:20

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by yurkin on 22 Aug 2013 at 9:20

GoogleCodeExporter commented 8 years ago 
Jacqueline den Hartogh has verified the fix on Ubuntu. So it was included in 
r1257

Original comment by yurkin on 27 Aug 2013 at 12:30

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Is this really fixed, because I got the same error on line 34?

Original comment by janityyn...@gmail.com on 4 Nov 2014 at 12:22

GoogleCodeExporter commented 8 years ago 
Jani, please provide more details. Which revision are you using (there has not 
been a stable release since that fix)? What is your operating system? What 
error message do you get?

Original comment by yurkin on 5 Nov 2014 at 6:37

GoogleCodeExporter commented 8 years ago 
My ADDA version is 1.2. Operating system is Ubuntu 14.04.1 LTS. However, I was 
unable to replicate this error.

Original comment by janityyn...@gmail.com on 13 Nov 2014 at 8:16

GoogleCodeExporter commented 8 years ago 
OK, the fix was after 1.2 release. And the replication of issue may depend on 
the default shell, which may change due to many different factors.

Original comment by yurkin on 13 Nov 2014 at 9:01