search

guaix-ucm / megaradrp

MEGARA (Multi-Espectrógrafo en GTC de Alta Resolución para Astronomía) is a facility instrument designed for the 10.4m GTC telescope in La Palma (Spain).
https://guaix.fis.ucm.es/megara/
GNU General Public License v3.0
12 stars 6 forks source link

TraceMap fails for "not-so-faint" fibers. The relative_threshold requirement does not change the result #273

Open gildepaz opened 4 years ago

gildepaz commented 4 years ago

TraceMap fails for "not-so-faint" fibers but the relative_threshold requirement does not change the result. Would it be possible to change the trace.py so it reads the relative_threshold requirement? Thx!

sergiopasra commented 4 years ago

Yes, relative_threshold is not used. I need a test dataset anyway

sergiopasra commented 4 years ago

Yes, relative_threshold is not used.

Well, it's a little more complex than that. It is used if and only if there is no predefined value. But there is a value of relative_threshold predefined for all the VPH/INSMODE combination, so the passed value is never used