search

guaix-ucm / megaradrp

MEGARA (Multi-Espectrógrafo en GTC de Alta Resolución para Astronomía) is a facility instrument designed for the 10.4m GTC telescope in La Palma (Spain).
https://guaix.fis.ucm.es/megara/
GNU General Public License v3.0
12 stars 6 forks source link

megaradrp-overplot_traces.py not backward compatible #280

Closed gildepaz closed 4 years ago

gildepaz commented 4 years ago

megaradrp-overplot_traces.py is not compatible with traces generated during the MEGARA commissioning. Date-obs field, for example, seems to be mandatory and it is not included in the old master_traces.json files. I have included that info by hand but I think megaradrp-overplot_traces.py should be able to handle master_traces.json files that lack that info, especially until the offsets are computed automatically based on temperature and date.

sergiopasra commented 4 years ago

If the missing key is date_obs and the file has insconf_uuid, the program should work, so I'm going to fix it. Other missing keys can be more problematic.

sergiopasra commented 4 years ago

Closed via https://github.com/guaix-ucm/megaradrp/commit/9760c6344d817ee38f0b068b0a0f592f32323cfa