guaix-ucm / megaradrp

MEGARA (Multi-Espectrógrafo en GTC de Alta Resolución para Astronomía) is a facility instrument designed for the 10.4m GTC telescope in La Palma (Spain).
https://guaix.fis.ucm.es/megara/
GNU General Public License v3.0
12 stars 6 forks source link

smoothing_knots has a default of None instead of 3 #302

Closed sergiopasra closed 2 years ago

sergiopasra commented 2 years ago

We added a new parameter smoothing_knots to LCBStandardRecipe. It's default value must be 3 (previous hard coded value), but we are getting None if the parameter is not defined.

Traceback (most recent call last):

  File "/Users/criscabe/opt/anaconda3/envs/py36/lib/python3.6/site-packages/numina/array/numsplines.py", line 136, in __init__

    nknots = int(t)

TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
sergiopasra commented 2 years ago

FYI @criscabe