search

guancio / ChromeOsSubtitle

ChromeOsSubtitle video player
63 stars 33 forks source link

7.1 Audio plays with channels missing #90

Open mcrivera11 opened 7 years ago

mcrivera11 commented 7 years ago

I have 5.1 Surround .flac files that play very well on your extension, but when I load 7.1 (8-channels) .flac files the sound is not played correctly; for example a movie audio track, where the voices of the actors can't be heard. Everything's ok when playing through Chrome's built-in player Ctrl+O, though.

Please fix this bug and make us appreciate your extension with even more power. Many thanks.

mcrivera11 commented 7 years ago

**Of all videoplayer apps available for Chrome, this is the one that sounds better, very well equalized. Good job!

vivekannan commented 7 years ago

Hello!

Thanks for bringing this up. Could you provide a sample video file? Something small preferably. On a side note, are you willing to give the latest version of the app a try? We have quite a few improvements that have been waiting to go out for quite some time now.

On Tue, Sep 12, 2017 at 4:43 AM, mcrivera11 notifications@github.com wrote:

**Of all videoplayer apps available for Chrome, this is the one that sounds better, very well equalized. Good job!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/guancio/ChromeOsSubtitle/issues/90#issuecomment-328684822, or mute the thread https://github.com/notifications/unsubscribe-auth/AHkl-jBDZxa-hOfKih-grlUXb7yCOancks5shb61gaJpZM4PTp3i .

mcrivera11 commented 7 years ago

Here goes the sample: sample7.1.zip The voices can be heard when you give it a play on the Chrome local player or any other player like VLC. In this extension, no voices and only the background sound.

Sure, I'd love to test it! Send me instructions.

vivekannan commented 7 years ago

Hey, I found the issue. The app uses Web Audio API to provide volume amplification and audio delay capabilities. For some reason, 7.1 channel audio is mishandled by the API (drops 1 or more channels). I will continue looking into this. Any help from your end will be.....helpful. Is the channel drop happening for all 7.1 videos?

About the beta testing; I will send you a zip in a while that you can add as an extension into your browser.

On Tue, Sep 12, 2017 at 11:39 PM, mcrivera11 notifications@github.com wrote:

Here goes the sample: sample7.1.zip https://github.com/guancio/ChromeOsSubtitle/files/1296933/sample7.1.zip The voices can be heard when you give it a play on the Chrome local player or any other player like VLC. In this extension, no voices and only the background sound.

Sure, I'd love to test it! Send me instructions.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/guancio/ChromeOsSubtitle/issues/90#issuecomment-328936331, or mute the thread https://github.com/notifications/unsubscribe-auth/AHkl-pG5EQ4-R1dnlhsbx8wKUU79ojacks5shsjvgaJpZM4PTp3i .

mcrivera11 commented 7 years ago

Yes, all videos with 8 audio channels play only 6. I've found some literature that may be of good use to you: HTML5_book.zip Check out the Chapter 9, page 331.

mcrivera11 commented 7 years ago

**Oh, and I tested all videoplayer apps for Chrome as well and yours is the only one with this issue. Still it's the one I like the most and I'll remain here.

vivekannan commented 7 years ago

I have attached a file with this comment. Download it. Extract it. Follow the steps listed here https://developer.chrome.com/extensions/getstarted#unpacked to load the folder as an app. It should now appear in your app menu. You can uninstall the older version to avoid confusion.

This app contains a few improvements over the older version. Given your specific case, I have removed the app's ability to amplify volume beyond 100% and also the audio delay feature. This seems to have solved the missing channels issue, I will continue to look for the actual solution. In the meantime, any feedback from you on this version of the app will be very useful. Whenever you come across the app misbehaving, a screenshot of the developer's console (Ctrl+Shift+J) would be helpful for me to debug the issue. Thanks again for bringing up this issue!

Improvements include: New screenshot shortcut (p). Partial FLV support. Some bug fixes.

app.zip

mcrivera11 commented 7 years ago

It worked! Brilliantly. Everything's running just fine now, and it's not only it; The bass is very improved, giving the videos a punch of reality, yet not interfering with other higher frequencies. I liked the new volume design, larger and easier to control.

After installing the app I just got one warning message: "There were warnings when trying to install this extension: 'webview' is not allowed for specified extension ID."

But it didn't stop me from running it.

I really recommend you to keep this audio configuration for the final next release, it's pretty good. While on it, I'm gonna keep this modification you've made for me and have loads of fun.

Thank you very much, and have a good work.

mcrivera11 commented 7 years ago

I've tested every single Video Player, Multimedia Centres available for Windows and Linux, and this App wins the 1st place. I use it on Vivaldi browser to playback even better. Give it a try and see if you like!