guanw / ct-dns

service discovery with support for different storage options + http/grpc protocols (WIP)
0 stars 0 forks source link

apply factory pattern to initialzie storage #25

Closed guanw closed 4 years ago

guanw commented 4 years ago

fix #7

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.23%. The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #25      +/-   ##
=========================================
+ Coverage   93.07%   93.3%   +0.23%     
=========================================
  Files           7      11       +4     
  Lines         231     269      +38     
=========================================
+ Hits          215     251      +36     
- Misses         10      11       +1     
- Partials        6       7       +1
Impacted Files Coverage Δ
plugins/storage/dynamodb/client.go 86.2% <ø> (ø)
plugins/storage/memory/client.go 100% <ø> (ø)
plugins/storage/etcd/client.go 100% <ø> (ø)
plugins/storage/memory/factory.go 100% <100%> (ø)
plugins/storage/factory.go 100% <100%> (ø)
pkg/store/store.go 100% <100%> (ø) :arrow_up:
plugins/storage/dynamodb/factory.go 100% <100%> (ø)
plugins/storage/etcd/factory.go 88.23% <88.23%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f069473...f0c803d. Read the comment docs.