guanyz / pe

0 stars 0 forks source link

Inconsistent error message for various delete commands with invalid index #9

Open guanyz opened 3 years ago

guanyz commented 3 years ago

Usually, delete commands' error messages will tell you that the index is invalid and will provide a valid range:

image.png

However, in some cases this fails and it gives the ‘wrong format’ error message, even when the given index is a positive integer.

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent error messages

Steps to reproduce: odel 12121212 odel 121212121212

Expected: Similar error that the index is not in range

Actual: One specifies that the index is invalid, another specifies that the command format is incorrect. However, following the error message provided, a INDEX param was provided and it is positive.

Screenshot 2021-04-16 at 2.54.32 PM.png Screenshot 2021-04-16 at 2.56.13 PM.png


[original: nus-cs2103-AY2021S2/pe-interim#2799] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Severity justification: Does not affect the normal operation of the app, may be an issue in some rare situations. Duplicate justification: Similar inconsistencies are shown as the underlying implementation of index is int instead of BigInteger. They can all be addressed by changing this implementation.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]